Add new function to add endpoint #3381

estringana · 2025-08-18T13:17:14Z

Description

Reviewer checklist

Test coverage seems ok.
Appropriate labels assigned.

codecov-commenter · 2025-08-25T16:08:21Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.76%. Comparing base (83b4cf2) to head (0d9977d).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3381   +/-   ##
=======================================
  Coverage   61.76%   61.76%           
=======================================
  Files         142      142           
  Lines       12895    12895           
  Branches     1689     1689           
=======================================
  Hits         7965     7965           
  Misses       4171     4171           
  Partials      759      759

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83b4cf2...0d9977d. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pr-commenter · 2025-08-25T16:40:00Z

Benchmarks [ tracer ]

Benchmark execution time: 2025-10-30 13:08:53

Comparing candidate commit 0d9977d in PR branch estringana/collect-framework-endpoints with baseline commit 83b4cf2 in branch master.

Found 10 performance improvements and 12 performance regressions! Performance is the same for 172 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

🟩 execution_time [-1357.325ns; -442.675ns] or [-11.803%; -3.849%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

🟩 execution_time [-3.269µs; -2.471µs] or [-3.173%; -2.399%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

🟩 execution_time [-5.935µs; -5.305µs] or [-5.713%; -5.107%]

scenario:PDOBench/benchPDOOverhead

🟩 execution_time [-60.261µs; -56.131µs] or [-22.803%; -21.240%]

scenario:PDOBench/benchPDOOverhead-opcache

🟩 execution_time [-60.875µs; -57.080µs] or [-23.312%; -21.859%]

scenario:PDOBench/benchPDOOverheadWithDBM

🟩 execution_time [-61.331µs; -57.280µs] or [-23.242%; -21.707%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

🟩 execution_time [-60.840µs; -56.256µs] or [-23.268%; -21.514%]

scenario:PHPRedisBench/benchRedisOverhead

🟩 execution_time [-284.740µs; -248.202µs] or [-26.819%; -23.378%]

scenario:PHPRedisBench/benchRedisOverhead-opcache

🟩 execution_time [-299.319µs; -264.498µs] or [-27.587%; -24.378%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

🟥 execution_time [+66.153ns; +131.847ns] or [+5.645%; +11.252%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

🟥 execution_time [+50.703ns; +110.297ns] or [+4.261%; +9.269%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

🟥 execution_time [+80.724ns; +157.676ns] or [+6.920%; +13.516%]

scenario:SpanBench/benchOpenTelemetryAPI

🟥 mem_peak [+1.465MB; +1.479MB] or [+3.526%; +3.561%]

scenario:SymfonyBench/benchSymfonyDdprof

🟥 execution_time [+3.692ms; +3.807ms] or [+43.534%; +44.897%]

scenario:SymfonyBench/benchSymfonyDdprof-opcache

🟥 execution_time [+3.650ms; +3.782ms] or [+42.742%; +44.281%]

scenario:SymfonyBench/benchSymfonyOverhead

🟥 execution_time [+3.551ms; +3.656ms] or [+44.855%; +46.184%]

scenario:SymfonyBench/benchSymfonyOverhead-opcache

🟥 execution_time [+3.535ms; +3.644ms] or [+44.102%; +45.465%]

scenario:TraceSerializationBench/benchSerializeTrace

🟩 execution_time [-37.707µs; -26.793µs] or [-8.485%; -6.029%]

scenario:WordPressBench/benchWordPressDdprof

🟥 execution_time [+1.990ms; +2.238ms] or [+6.777%; +7.622%]

scenario:WordPressBench/benchWordPressDdprof-opcache

🟥 execution_time [+2.067ms; +2.192ms] or [+7.051%; +7.477%]

scenario:WordPressBench/benchWordPressOverhead

🟥 execution_time [+2.067ms; +2.257ms] or [+7.581%; +8.278%]

scenario:WordPressBench/benchWordPressOverhead-opcache

🟥 execution_time [+2.012ms; +2.218ms] or [+7.330%; +8.082%]

estringana · 2025-09-29T10:11:44Z

appsec/tests/extension/add_endpoints.phpt

@@ -0,0 +1,13 @@
+--TEST--


Ignore this file

estringana · 2025-09-29T10:12:12Z

components-rs/crashtracker.h




+typedef enum  ddog_crasht_CrashInfoBuilder_NewResult_Tag {


This file got autogenerated

estringana · 2025-09-29T10:16:15Z

Cargo.lock

 "backtrace",
 "blazesym",
 "cc",
- "cc_utils",


This got removed automatically. Not sure why

estringana · 2025-09-29T12:48:08Z

src/DDTrace/Integrations/Laravel/LaravelIntegration.php

             }
        );

+        if (!\DDTrace\are_endpoints_collected()) {


This will be adapted. Just an idea of how it will be used

Co-authored-by: Gustavo Lopes <[email protected]>

estringana force-pushed the estringana/collect-framework-endpoints branch from 96601ba to 791f8e7 Compare August 27, 2025 10:38

estringana commented Sep 29, 2025

View reviewed changes

appsec/tests/extension/add_endpoints.phpt Outdated

@@ -0,0 +1,13 @@

--TEST--

Copy link

Contributor Author

estringana Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this file

estringana commented Sep 29, 2025

View reviewed changes

Cargo.lock Outdated

"backtrace",

"blazesym",

"cc",

"cc_utils",

Copy link

Contributor Author

estringana Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got removed automatically. Not sure why

estringana commented Sep 29, 2025

View reviewed changes

estringana force-pushed the estringana/collect-framework-endpoints branch from f5413d6 to e1212be Compare October 6, 2025 08:39

cataphract force-pushed the estringana/collect-framework-endpoints branch from 1a9903d to e1212be Compare October 10, 2025 09:55

estringana force-pushed the estringana/collect-framework-endpoints branch 3 times, most recently from e2c597b to b66e5b7 Compare October 21, 2025 15:25

estringana added 18 commits October 30, 2025 12:59

Add new function to add endpoint

eafe49c

Aproaching solution

bf6ef5d

Use shared cache instead of local

8de4a07

wip

55e7dcb

Used last push endpoints

bd8bc8c

Tests passing

1235bd8

Fix rebase errors

c9514a5

wip

8ae0add

Update generated files

d98e989

Make string vectors work

a08586c

wip

3c355d8

Add i32 vector

c516e3b

Add authentication vector

2cf07ed

Add serde json

f5aa2d2

Remove debugging lines

bfb2d7b

Replace char_c for slices

68aa07d

Amend PR comments

f185f7c

Strip invalid utf8 chars

4211e60

estringana and others added 26 commits October 30, 2025 13:00

Send Laravel endpoints

9403801

Point to latest

61eb427

Fix add-routes-collection (#3446)

ca5cf2d

Co-authored-by: Gustavo Lopes <[email protected]>

Point to latest libdatadog

68dc49e

Remove response_code

aa348f6

Remove non used fields

830884d

Point to latest

02a0720

Generate cbindgen

03941a7

Test Laravel integration

cbe85ce

Refactor telemetry collection on appsec integration tests

e6ad060

Point to latest

bbe737b

Remove non necessary file

87490b0

Update php stub

1abd81a

Generate common

d2e08c7

Amend laravel compatibility

0752ee1

Revert non required changes

a8047a4

Play defensive on Laravel Integration

0a96e38

Get routes from Symfony

990823a

Amend issue with drupal

7fadcfd

Add wordpress integration

e68f881

wip

c44fb8f

Test laravel

8022af8

Test symfony

b4c4ff2

Fix latest symfony

1965e4b

Fix old symfony versions tests

c54357b

Fix some symfony failing versions

0d9977d

estringana force-pushed the estringana/collect-framework-endpoints branch from f02430a to 0d9977d Compare October 30, 2025 12:00

bwoebi force-pushed the master branch from 0c3739f to 789048a Compare November 6, 2025 18:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add new function to add endpoint #3381

Add new function to add endpoint #3381

Uh oh!

estringana commented Aug 18, 2025

Uh oh!

codecov-commenter commented Aug 25, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Aug 25, 2025 •

edited

Loading

Uh oh!

estringana Sep 29, 2025

Uh oh!

estringana Sep 29, 2025

Uh oh!

estringana Sep 29, 2025

Uh oh!

estringana Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add new function to add endpoint #3381

Are you sure you want to change the base?

Add new function to add endpoint #3381

Uh oh!

Conversation

estringana commented Aug 18, 2025

Description

Reviewer checklist

Uh oh!

codecov-commenter commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pr-commenter bot commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks [ tracer ]

scenario:ComposerTelemetryBench/benchTelemetryParsing

scenario:MessagePackSerializationBench/benchMessagePackSerialization

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

scenario:PDOBench/benchPDOOverhead

scenario:PDOBench/benchPDOOverhead-opcache

scenario:PDOBench/benchPDOOverheadWithDBM

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

scenario:PHPRedisBench/benchRedisOverhead

scenario:PHPRedisBench/benchRedisOverhead-opcache

scenario:SamplingRuleMatchingBench/benchRegexMatching2

scenario:SamplingRuleMatchingBench/benchRegexMatching3

scenario:SamplingRuleMatchingBench/benchRegexMatching4

scenario:SpanBench/benchOpenTelemetryAPI

scenario:SymfonyBench/benchSymfonyDdprof

scenario:SymfonyBench/benchSymfonyDdprof-opcache

scenario:SymfonyBench/benchSymfonyOverhead

scenario:SymfonyBench/benchSymfonyOverhead-opcache

scenario:TraceSerializationBench/benchSerializeTrace

scenario:WordPressBench/benchWordPressDdprof

scenario:WordPressBench/benchWordPressDdprof-opcache

scenario:WordPressBench/benchWordPressOverhead

scenario:WordPressBench/benchWordPressOverhead-opcache

Uh oh!

estringana Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

estringana Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

estringana Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

estringana Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Aug 25, 2025 •

edited

Loading

pr-commenter bot commented Aug 25, 2025 •

edited

Loading